rohangarg commented on code in PR #14453:
URL: https://github.com/apache/druid/pull/14453#discussion_r1235065553
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataCache.java:
##########
@@ -403,6 +403,13 @@ public void start() throws InterruptedException
@VisibleForTesting
void refresh(final Set<SegmentId> segmentsToRefresh, final Set<String>
dataSourcesToRebuild) throws IOException
{
+ long startMillis = System.currentTimeMillis();
Review Comment:
I think the monotonicity depends on the NTP updates (on cloud instances), so
not sure doing from same thread affects it. Also regarding cheapness, I think
both calls are cheap and infrequent enough to not become a bottleneck for
performance consideration. Further, the performance of each is also platform
dependent I think.
I felt that for elapsed durations, probably something closer to a timer is
better than using clock times.
Anyways, I'm ok with using any method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
