kfaraz commented on code in PR #14453:
URL: https://github.com/apache/druid/pull/14453#discussion_r1236219891
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SegmentMetadataCache.java:
##########
@@ -403,6 +403,13 @@ public void start() throws InterruptedException
@VisibleForTesting
void refresh(final Set<SegmentId> segmentsToRefresh, final Set<String>
dataSourcesToRebuild) throws IOException
{
+ long startMillis = System.currentTimeMillis();
+
+ emitter.emit(ServiceMetricEvent.builder().build(
Review Comment:
No, just add the dimension `dataSource` while emitting the metric.
Aggregation is not required. It can be summed up wherever the metric is being
collected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
