gianm commented on PR #14537: URL: https://github.com/apache/druid/pull/14537#issuecomment-1636309108
Hmm, something seems odd about firing a future and never doing anything with the return (other than logging it). What happens if another CompactSegments runs before the first one's `runTask` completes? Would it try to run the task again because it doesn't see it running? Would it properly track the number of concurrently running compaction tasks? What do you think about an alternate approach using different threads for different duty cycles? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
