kfaraz commented on PR #14537: URL: https://github.com/apache/druid/pull/14537#issuecomment-1636630256
Thanks for the feedback, @gianm . I had similar thoughts which is why I held off on this PR (forgot to mark this `WIP`). My intention was to: - track the tasks being submitted until the future completes so that duplicate tasks are not submitted if another `CompactSegments` is invoked before all the futures have completed. - emit metrics and clean up this state on future completion - probably also have some kind of submission timeout so that futures don't wait indefinitely -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
