kfaraz commented on PR #14537: URL: https://github.com/apache/druid/pull/14537#issuecomment-1636630456
> What do you think about an alternate approach using different threads for different duty cycles? Yes, that is the other approach I had in mind. I was a little concerned about race conditions between different duty groups. But the right design would be to break up the duty groups in such a way that they are completely independent and parallelizable (which is most likely already the case). I went ahead with this approach instead as it retained the same flow and only made task submission async. All the other overlord operations done by the `CompactSegments` duty such as fetching running compaction tasks are still being done synchronously. So there is still a possibility of the coordinator run being blocked. This approach seemed simpler originally but now it seems like a half measure and probably brings in more complications than necessary. We already have a PR for using the OverlordClient. So I will go ahead and update this PR to simply use different threads for different duty groups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
