cryptoe commented on code in PR #14571:
URL: https://github.com/apache/druid/pull/14571#discussion_r1265169904
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/MSQDestination.java:
##########
@@ -30,5 +31,5 @@
})
public interface MSQDestination
{
- // No methods. Just a marker interface for deserialization.
+ ResultFormat getResultFormat();
Review Comment:
Lets document how this interface is used here.
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/MSQDestination.java:
##########
@@ -30,5 +31,5 @@
})
public interface MSQDestination
{
- // No methods. Just a marker interface for deserialization.
+ ResultFormat getResultFormat();
Review Comment:
hmm this seems like the destination is marked with "x" result format which
is not the case in taskReports as well as DurableStorageDestination.
Since we have the context of the query passed to the task, is this change
required.
We can just look as the taskPayload to figure out the "resultFormat" passed
on the post statement always .
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
