LakshSingla commented on code in PR #14571:
URL: https://github.com/apache/druid/pull/14571#discussion_r1260931609
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/DataSourceMSQDestination.java:
##########
@@ -160,4 +163,11 @@ public String toString()
", replaceTimeChunks=" + replaceTimeChunks +
'}';
}
+
+ @Override
+ @JsonIgnore
Review Comment:
We can remove @JsonIgnore since this method is throwing an exception anyways
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java:
##########
@@ -115,6 +117,7 @@
public class SqlStatementResource
{
+ public static final String RESULT_FORMAT = "resultFormat";
Review Comment:
Since this is a restricted parameter for the user, this should also be added
here
https://github.com/apache/druid/blob/2d8e0f28f36f83e091911cc7b36a57b10fd065cc/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/MSQTaskSqlEngine.java#L58
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/DataSourceMSQDestination.java:
##########
@@ -160,4 +163,11 @@ public String toString()
", replaceTimeChunks=" + replaceTimeChunks +
'}';
}
+
+ @Override
+ @JsonIgnore
Review Comment:
We can remove @JsonIgnore since this method is throwing an exception anyways
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
