adarshsanjeev commented on code in PR #14571:
URL: https://github.com/apache/druid/pull/14571#discussion_r1281708406
##########
sql/src/main/java/org/apache/druid/sql/http/SqlQuery.java:
##########
@@ -66,7 +66,7 @@ public SqlQuery(
)
{
this.query = Preconditions.checkNotNull(query, "query");
- this.resultFormat = resultFormat == null ? ResultFormat.OBJECT :
resultFormat;
+ this.resultFormat = resultFormat == null ?
ResultFormat.DEFAULT_RESULT_FORMAT : resultFormat;
Review Comment:
This is the default format when nothing is specified at all, but it is only
specified in this class. It would be better if this was clearly specified so
that it could be reused (or changed in the future), so I added
`DEFAULT_RESULT_FORMAT`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
