imply-cheddar commented on PR #14462: URL: https://github.com/apache/druid/pull/14462#issuecomment-1670262656
This PR doesn't actually solve hte problem it needs to solve as the columns that itproduces will be extremely large compared to the expected size. The complex column serde needs to follow the pattern followed by `SerializedPairLongStringComplexMetricSerde`. It's not okay to use the normal `GenericIndexed` for these columns. While I'm not against merging this just to get something in place, I am against this code existing in any release as it will mean that some people might actually create segments with incredibly large columns, not realizing why, and hten we have to carry forward the bad versions of the code to read those columns back out all because we just didn't implement it according to the already existing pattern the first time around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
