ankit0811 commented on code in PR #14462:
URL: https://github.com/apache/druid/pull/14462#discussion_r1281535560
##########
processing/src/main/java/org/apache/druid/query/aggregation/first/FloatFirstAggregatorFactory.java:
##########
@@ -281,7 +236,7 @@ public byte[] getCacheKey()
public ColumnType getIntermediateType()
{
// if we don't pretend to be a primitive, group by v1 gets sad and doesn't
work because no complex type serde
Review Comment:
Wont this throw an exception as `AggregateFactory::getIntermediateType`
default implementation calls `getType` which throws
`UnsupportedOperationException` and looks like the doc says `getType` will be
deprecated in support of `getIntermediateType`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
