kfaraz opened a new pull request, #14616:
URL: https://github.com/apache/druid/pull/14616
### Description
Follow up to #11717
This PR attempts to fix the following sequence of events:
1. Historical receives HTTP request to load segment S.
2. Load succeeds and the cache now has an entry to the effect "LOAD S was
SUCCESS".
3. HTTP request completes with SUCCESS but the entry is still there in the
cache.
4. Historical receives request to drop segment S and request finishes
successfully but cache still has entry for "LOAD S was SUCCESS"
5. Historical receives request to reload segment S. Since we already have an
entry in cache, historical responds with "LOAD S was SUCCESS" even though the
segment has already been dropped from the historical.
### Changes
- Remove entry from cache as soon as it is consumed to be sent back to the
client
- Fix test
### Release note
TODO
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
