gianm commented on code in PR #14616:
URL: https://github.com/apache/druid/pull/14616#discussion_r1268552052
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java:
##########
@@ -789,15 +789,20 @@ private CustomSettableFuture(
public void resolve()
{
- synchronized (statusRefs) {
+ synchronized (requestStatusesLock) {
Review Comment:
Thanks for the explanation. It looks like there is no longer anything
synchronizing on `statusRefs`, so the new code is somewhat simpler. Please do
add a comment to `requestStatusesLock`, or use `@GuardedBy` on the things it is
meant to guard, as appropriate, in order to make the logic easier to follow for
others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
