cryptoe commented on code in PR #14629:
URL: https://github.com/apache/druid/pull/14629#discussion_r1269546029
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/sql/resources/SqlStatementResource.java:
##########
@@ -848,24 +849,25 @@ private void contextChecks(QueryContext queryContext)
}
MSQSelectDestination selectDestination =
MultiStageQueryContext.getSelectDestination(queryContext);
- if (selectDestination == MSQSelectDestination.DURABLE_STORAGE) {
- checkForDurableStorageConnectorImpl();
+ if (MSQSelectDestination.DURABLESTORAGE.equals(selectDestination)) {
+ checkForDurableStorageConnectorImpl(NodeRole.BROKER);
}
}
- private void checkForDurableStorageConnectorImpl()
+ private void checkForDurableStorageConnectorImpl(NodeRole nodeRole)
Review Comment:
I initially envisioned to move the check out of this class but I decided
against it. Hence this is left over code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
