LakshSingla commented on code in PR #14629:
URL: https://github.com/apache/druid/pull/14629#discussion_r1269691112
##########
docs/multi-stage-query/reference.md:
##########
@@ -377,7 +377,11 @@ When you run a query, include the context parameter
`durableShuffleStorage` and
For queries where you want to use fault tolerance for workers, set
`faultTolerance` to `true`, which automatically sets `durableShuffleStorage` to
`true`.
-For select queryies which want to write the final result to `durableStoage`,
set `selectDestination`:`durableStorage`. Which shuffle mesh the job uses can
still be controller by `durableShuffleStorage` flag ie. a combination where
`selectDestination`:`durableStorage` and `durableShuffleStorage`:`false` is
perfectly valid.
+Set `selectDestination`:`durableStorage` for select queries that want to write
the final results to durable storage instead of the task reports. Saving the
results in the durable
+storage allows users to fetch large result sets. The location where the
workers write the intermediate results is different than the location where
final results get stored. Therefore, `durableShuffleStorage`:`false` and
Review Comment:
```suggestion
storage allows users to fetch large result sets. The location where the
workers write the intermediate results can be different from the location where
the final results get stored. Therefore, `durableShuffleStorage`:`false` and
```
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/destination/MSQSelectDestination.java:
##########
@@ -27,21 +29,38 @@ public enum MSQSelectDestination
/**
* Writes all the results directly to the report.
*/
- TASK_REPORT(false),
+ TASKREPORT("taskReport", false),
Review Comment:
Cool!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
