kfaraz commented on PR #14643: URL: https://github.com/apache/druid/pull/14643#issuecomment-1647260755
I agree, we should not update the super class. The `result` field is not serializable and is there in the super class just for convenience. You can pass a null to it. Since we have a specific use case, it is okay to override the default behaviour. You would need to maintain the `result` field at the `KubernetesWorkItem` level and override the `getResult` method to return this instead of the one being returned by the super class. If `KubernetesWorkItem` does not take a future in its constructor, then users would naturally know to have to set it. You can add javadocs to that effect. So I am not sure the error prone concern is really valid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
