kfaraz commented on PR #14643: URL: https://github.com/apache/druid/pull/14643#issuecomment-1647262589
> Though synchronized on tasks in all the operations seems overkill as it's already a ConcurrentHashMap but it makes the class more thread-safe (in theory). Yeah, it is certainly thread-safe (even in practice) to have everything be synchronized under the same lock but also limits performance. A single bad call can potentially block everything. We are trying to revisit all usages of locks in the Druid code base, and the original PR #14435 was in that same vein. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
