zachjsh opened a new pull request, #14662:
URL: https://github.com/apache/druid/pull/14662
### Description
This change makes various improvements to Druid's auto kill coordinator
duty, which periodically checks for and deletes unused segments.
Previously, the `maxSegments` configured for auto kill could be ignored if
an interval of data for a given datasource had more than this number of unused
segments, causing the kill task spawned with the task of deleting unused
segments in that given interval of data to delete more than the `maxSegments`
configured. Now each kill task spawned by the auto kill coordinator duty, will
kill at most `maxSegments` segments.
Also added a CoordinatorDynamicConfig property `killTaskSlotRatio`, which
allows the user to control the maximum number of kill task slots in use in the
cluster, as spawned by Druid's auto kill coordinator duty. This considers the
total task capacity in the cluster, with autoscaling if configured, and allows
for only that respective number of active kill tasks at a given time in the
cluster, as spawned by the auto kill duty.
TODO: add more tests, update docs
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
