kfaraz commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1274565717
##########
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java:
##########
@@ -444,6 +454,9 @@ public boolean equals(Object o)
&& Objects.equals(
specificDataSourcesToKillUnusedSegmentsIn,
that.specificDataSourcesToKillUnusedSegmentsIn)
+ && Objects.equals(
Review Comment:
Nit: can be in a single line.
##########
server/src/main/java/org/apache/druid/server/coordinator/CoordinatorDynamicConfig.java:
##########
@@ -532,6 +547,7 @@ public Builder(
@JsonProperty("replicationThrottleLimit") @Nullable Integer
replicationThrottleLimit,
@JsonProperty("balancerComputeThreads") @Nullable Integer
balancerComputeThreads,
@JsonProperty("killDataSourceWhitelist") @Nullable Object
specificDataSourcesToKillUnusedSegmentsIn,
+ @JsonProperty("killTaskSlotRatio") @Nullable Double killTaskSlotRatio,
Review Comment:
I am not sure if we really need this config. Have we seen cases where the
Overlord gets bombarded with too many kill tasks?
This is used for a cleanup duty which already exposes other knobs to control
how much cleanup it does, such as its `period` and `durationToRetain`.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -78,6 +84,9 @@ public KillUnusedSegmentsTask(
context
);
this.markAsUnused = markAsUnused != null && markAsUnused;
+ Preconditions.checkArgument(maxSegmentsToKill > 0, "maxSegmentsToKill must
be > 0");
Review Comment:
Can this can throw an NPE if maxSegmentsToKill is null?
What is the default value of `maxSegmentsToKill`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
