zachjsh commented on code in PR #14662:
URL: https://github.com/apache/druid/pull/14662#discussion_r1275404235
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -78,6 +84,9 @@ public KillUnusedSegmentsTask(
context
);
this.markAsUnused = markAsUnused != null && markAsUnused;
+ Preconditions.checkArgument(maxSegmentsToKill > 0, "maxSegmentsToKill must
be > 0");
Review Comment:
yes! thanks. This is what was causing tests to fail. Fixed now. Default is
null, which indicates that there is no limit to the number of segments to
delete, which is the existing behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
