AmatyaAvadhanula commented on code in PR #14507:
URL: https://github.com/apache/druid/pull/14507#discussion_r1275747264
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialSegmentGenerateTask.java:
##########
@@ -109,7 +110,10 @@ abstract class PartialSegmentGenerateTask<T extends
GeneratedPartitionsReport> e
@Override
public final TaskStatus runTask(TaskToolbox toolbox) throws Exception
{
- final InputSource inputSource =
ingestionSchema.getIOConfig().getNonNullInputSource();
+ InputSource inputSource =
ingestionSchema.getIOConfig().getNonNullInputSource(toolbox);
+ if (inputSource instanceof TaskInputSource) {
Review Comment:
Yes, cleaned up
##########
indexing-service/src/main/java/org/apache/druid/indexing/input/DruidInputSource.java:
##########
@@ -237,6 +244,20 @@ public List<String> getMetrics()
return metrics;
}
+ @Override
+ public InputSource withTaskToolbox(TaskToolbox toolbox)
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
