kfaraz commented on code in PR #14507:
URL: https://github.com/apache/druid/pull/14507#discussion_r1276342222
##########
indexing-service/src/main/java/org/apache/druid/indexing/input/DruidInputSource.java:
##########
@@ -167,6 +172,39 @@ public DruidInputSource(
@JacksonInject RetryPolicyFactory retryPolicyFactory,
@JacksonInject TaskConfig taskConfig
)
+ {
+ this(
+ dataSource,
+ interval,
+ segmentIds,
+ dimFilter,
+ dimensions,
+ metrics,
+ indexIO,
+ coordinatorClient,
+ segmentCacheManagerFactory,
+ retryPolicyFactory,
+ taskConfig,
+ null
+ );
+ }
+
+ private DruidInputSource(
+ final String dataSource,
+ @Nullable Interval interval,
+ // Specifying "segments" is intended only for when this FirehoseFactory
has split itself,
+ // not for direct end user use.
+ @Nullable List<WindowedSegmentId> segmentIds,
+ DimFilter dimFilter,
+ List<String> dimensions,
+ List<String> metrics,
+ IndexIO indexIO,
+ CoordinatorClient coordinatorClient,
+ SegmentCacheManagerFactory segmentCacheManagerFactory,
+ RetryPolicyFactory retryPolicyFactory,
+ TaskConfig taskConfig,
+ TaskToolbox toolbox
Review Comment:
Mark this as @Nullable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
