kfaraz commented on code in PR #14507:
URL: https://github.com/apache/druid/pull/14507#discussion_r1276331529
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java:
##########
@@ -245,7 +251,7 @@ public ParallelIndexSupervisorTask(
checkPartitionsSpecForForceGuaranteedRollup(ingestionSchema.getTuningConfig().getGivenOrDefaultPartitionsSpec());
}
- this.baseInputSource =
ingestionSchema.getIOConfig().getNonNullInputSource();
Review Comment:
Why are we getting rid of the old `getNonNullInputSource()`?
It had a nice validation being done in it.
We should just add a new `getNonNullInputSource(Toolbox)` instead of
replacing the old one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
