YongGang commented on code in PR #14743:
URL: https://github.com/apache/druid/pull/14743#discussion_r1283503228
##########
services/src/main/java/org/apache/druid/cli/CliMiddleManager.java:
##########
@@ -195,6 +202,18 @@ private void configureIntermediaryData(Binder binder)
biddy.addBinding("deepstore").to(DeepStorageIntermediaryDataManager.class).in(LazySingleton.class);
}
+ @Provides
+ @LazySingleton
+ @Named(ServiceStatusMonitor.TAGS_BINDING)
+ public Supplier<Map<String, Object>>
heartbeatDimensions(WorkerConfig workerConfig, WorkerTaskManager
workerTaskManager)
+ {
+ return () -> ImmutableMap.of(
+ "workerVersion", workerConfig.getVersion(),
Review Comment:
Should we try to make the dimensions as few as possible? Means to have a
general dimension name so it can be reused in other services, e.g.
`workerVersion` -> `version`, `workerCategory` -> `category`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
