suneet-s commented on code in PR #14743:
URL: https://github.com/apache/druid/pull/14743#discussion_r1283509613
##########
extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json:
##########
@@ -175,5 +175,5 @@
"namespace/cache/numEntries" : { "dimensions" : [], "type" : "gauge" },
"namespace/cache/heapSizeInBytes" : { "dimensions" : [], "type" : "gauge" },
- "service/heartbeat" : { "dimensions" : ["leader"], "type" : "gauge" }
+ "service/heartbeat" : { "dimensions" : ["leader"], "type" : "count" }
Review Comment:
From the [datadog
docs](https://docs.datadoghq.com/metrics/types/?tab=count#metric-types) - it
looks like a count metric reports the count of the metrics retrieved in that
interval and is not cumulative across intervals.
```
Suppose you are submitting a COUNT metric, activeusers.basket_size, from a
single host running the Datadog Agent. This host emits the following values in
a flush time interval: [1,1,1,2,2,2,3,3].
The Agent adds all of the values received in one time interval. Then, it
submits the total number, in this case 15, as the COUNT metric’s value.
```
From an analysis point, it is very useful to know how many heartbeats were
sent yesterday as it gives us an idea of uptime if we know how many heartbeats
are sent per minute.
##########
extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json:
##########
@@ -175,5 +175,5 @@
"namespace/cache/numEntries" : { "dimensions" : [], "type" : "gauge" },
"namespace/cache/heapSizeInBytes" : { "dimensions" : [], "type" : "gauge" },
- "service/heartbeat" : { "dimensions" : ["leader"], "type" : "gauge" }
+ "service/heartbeat" : { "dimensions" : ["leader"], "type" : "count" }
Review Comment:
From the [datadog
docs](https://docs.datadoghq.com/metrics/types/?tab=count#metric-types) - it
looks like a count metric reports the count of the metrics retrieved in that
interval and is not cumulative across intervals.
```
Suppose you are submitting a COUNT metric, activeusers.basket_size, from a
single host running the Datadog Agent. This host emits the following values in
a flush time interval: [1,1,1,2,2,2,3,3].
The Agent adds all of the values received in one time interval. Then, it
submits the total number, in this case 15, as the COUNT metric’s value.
```
From an analysis point, it is very useful to know how many heartbeats were
sent yesterday as it gives us an idea of uptime if we know how many heartbeats
are sent per minute.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
