suneet-s commented on code in PR #14743:
URL: https://github.com/apache/druid/pull/14743#discussion_r1283515039
##########
services/src/main/java/org/apache/druid/cli/CliMiddleManager.java:
##########
@@ -195,6 +200,18 @@ private void configureIntermediaryData(Binder binder)
biddy.addBinding("deepstore").to(DeepStorageIntermediaryDataManager.class).in(LazySingleton.class);
}
+ @Provides
+ @LazySingleton
+ @Named(ServiceStatusMonitor.HEARTBEAT_TAGS_BINDING)
+ public Supplier<Map<String, Object>>
heartbeatDimensions(WorkerConfig workerConfig, WorkerTaskManager
workerTaskManager)
+ {
+ return () -> ImmutableMap.of(
+ "workerVersion", workerConfig.getVersion(),
Review Comment:
In this instance I think more specific dimension names are helpful as it
clears up some confusion. eg. `version` can be misinterpreted - Should it be
the version of Druid that it is running or version of the worker.
If we find a dimension that should be reported on multiple services, this
would be good to consider
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
