somu-imply opened a new pull request, #14753:
URL: https://github.com/apache/druid/pull/14753
…r instead of BaseLongVectorValueSelector
Currently the existing factories were assuming that time would always be
BaseLongVectorValueSelector. This would cause issues for queries during
vectorization where the time can be an expression. For example
```
SELECT
LATEST_BY(num2,
MILLIS_TO_TIMESTAMP(BITWISE_SHIFT_RIGHT(TIMESTAMP_TO_MILLIS(__time), 3)))
FROM "signals" GROUP BY TIME_FLOOR(__time, 'P1Y', null, 'America/New_York')
Error: Unknown exception
org.apache.druid.segment.virtual.ExpressionVectorValueSelector cannot be
cast to org.apache.druid.segment.vector.BaseLongVectorValueSelector
java.lang.ClassCastException
```
This PR addresses the issue by removing BaseLongVectorValueSelector with the
VectorValueSelector. The test case has also been added to our unit tests
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
