abhishekagarwal87 commented on code in PR #14753:
URL: https://github.com/apache/druid/pull/14753#discussion_r1283940478


##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -853,6 +853,38 @@ public void testAnyAggregatorsOnHeapNumericNulls()
     );
   }
 
+  // This test is to check if expressions are accepted properly by the 
vectorized last aggregator
+  @Test
+  public void testLatestVectorAggregatorsOnExpression()

Review Comment:
   ```suggestion
     public void testLatestVectorAggregatorsOnTimeExpression()
   ```



##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -853,6 +853,38 @@ public void testAnyAggregatorsOnHeapNumericNulls()
     );
   }
 
+  // This test is to check if expressions are accepted properly by the 
vectorized last aggregator

Review Comment:
   ```suggestion
     // This test is to check if time expressions are accepted properly by the 
vectorized last aggregator
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to