georgew5656 opened a new pull request, #14789:
URL: https://github.com/apache/druid/pull/14789
Since the pod template adapter does not generate the internal peon ... run
command itself (the command is passed in the pod templates), we need a way to
account for the optional --load-broadcast-segments flag for tasks that are
queryable.
### Description
Based on the task being launched, pass whether the task can handle queries
as a environment variable to the job launched by the pod template adapter. The
operator can then configure their k8s command in the pod template to include
this env variable in the internal peon run command.
#### Release note
Allow the PodTemplateTaskAdapter to account for queryable tasks.
##### Key changed/added classes in this PR
* PodTemplateTaskAdapter
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [X] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
