YongGang commented on code in PR #14789:
URL: https://github.com/apache/druid/pull/14789#discussion_r1289001935
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/common/DruidK8sConstants.java:
##########
@@ -34,6 +34,7 @@ public class DruidK8sConstants
public static final String TASK_JSON_ENV = "TASK_JSON";
public static final String TASK_DIR_ENV = "TASK_DIR";
public static final String TASK_ID_ENV = "TASK_ID";
+ public static final String LOAD_BROADCAST_SEGMENTS_ENV =
"LOAD_BROADCAST_SEGMENTS";
Review Comment:
should this be `loadBroadcastSegments`?
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/taskadapter/PodTemplateTaskAdapter.java:
##########
@@ -224,7 +224,11 @@ private Collection<EnvVar> getEnv(Task task)
.withValueFrom(new EnvVarSourceBuilder().withFieldRef(new
ObjectFieldSelector(
null,
StringUtils.format("metadata.annotations['%s']",
DruidK8sConstants.TASK)
- )).build()).build()
+ )).build()).build(),
+ new EnvVarBuilder()
Review Comment:
My understanding is we what to do things similar to
[this](https://github.com/apache/druid/blob/master/extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/taskadapter/K8sTaskAdapter.java#L402-L405)
Is setting an env variable enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
