georgew5656 commented on code in PR #14789:
URL: https://github.com/apache/druid/pull/14789#discussion_r1289106284
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/taskadapter/PodTemplateTaskAdapter.java:
##########
@@ -224,7 +224,11 @@ private Collection<EnvVar> getEnv(Task task)
.withValueFrom(new EnvVarSourceBuilder().withFieldRef(new
ObjectFieldSelector(
null,
StringUtils.format("metadata.annotations['%s']",
DruidK8sConstants.TASK)
- )).build()).build()
+ )).build()).build(),
+ new EnvVarBuilder()
Review Comment:
this needs to be passed to the java druid internal peon command as a flag,
and in the PodTemplateTaskAdapter, we don't actually control how the user
configures that command.
But right now there's no way to even see whether the flag should be set,
since we set the environment variable here, the user can read it and choose to
set --loadBroadcastSegments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
