pranavbhole opened a new pull request, #14806:
URL: https://github.com/apache/druid/pull/14806
Fixes #14796.
### Description
This PR is major change is lookup container loading and dropping behavior
and avoid the lookup inconsistencies in update container call. It also
introduces the user defined SLA of loading the lookups, loading and dropping
behavior will avail this SLA and wait for new container to load.
Load Container call:
Starts the new container, if cache is loaded then drop the old container if
exists and start serving from new container.
If cache is not loaded then wait for container to come up with startRetries
times and then declare the new container as failed and kill new container,
still continue serving from old container.
Drop Container call:
We get drop call from 2 flow, Update and Delete call from lookups. Drop
Notice also accepts the optional loadedContainer.
LoadedContainer is only passed in update flow. We make sure that
loadedContainer is loaded with cache before dropping the existing container. If
cache is not loaded, wait for given SLA for loadedContainer to load.
If cache is loaded in loadedContainer then go ahead and drop it.
#### Release note
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
