clintropolis commented on code in PR #14806:
URL: https://github.com/apache/druid/pull/14806#discussion_r1295115638
##########
server/src/test/java/org/apache/druid/query/lookup/LookupReferencesManagerTest.java:
##########
@@ -526,6 +530,7 @@ public void testRealModeWithMainThread() throws Exception
LookupExtractorFactory lookupExtractorFactory =
EasyMock.createMock(LookupExtractorFactory.class);
EasyMock.expect(lookupExtractorFactory.start()).andReturn(true).once();
EasyMock.expect(lookupExtractorFactory.destroy()).andReturn(true).once();
+
EasyMock.expect(lookupExtractorFactory.isCacheLoaded()).andReturn(true).anyTimes();
Review Comment:
it would be nice to add some tests that simulate sad paths where the new
lookup does not load to ensure proper behavior where the new container is
destroyed and old container is still operational, and also tests where new
doesn't initially load and so goes through the retry path but then successfully
loads and the old is destroyed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
