clintropolis commented on code in PR #14806:
URL: https://github.com/apache/druid/pull/14806#discussion_r1304982870
##########
extensions-core/lookups-cached-global/src/main/java/org/apache/druid/query/lookup/namespace/JdbcExtractionNamespace.java:
##########
@@ -73,6 +75,7 @@ public JdbcExtractionNamespace(
@JsonProperty(value = "filter") @Nullable final String filter,
@Min(0) @JsonProperty(value = "pollPeriod") @Nullable final Period
pollPeriod,
@JsonProperty(value = "maxHeapPercentage") @Nullable final Long
maxHeapPercentage,
+ @JsonProperty(value = "loadTimeout") @Nullable final Long loadTimeout,
Review Comment:
we should update the docs if we are adding a new parameter
##########
extensions-core/kafka-extraction-namespace/src/main/java/org/apache/druid/query/lookup/KafkaLookupExtractorFactory.java:
##########
@@ -297,6 +297,18 @@ public LookupIntrospectHandler getIntrospectHandler()
return new KafkaLookupExtractorIntrospectionHandler(this);
}
+ @Override
+ public void awaitInitialization()
+ {
+
Review Comment:
i guess this doesn't need await because its continuously updated instead of
swapped? if that is the case could you leave a comment? or if not the case,
explain why it doesn't need to wait on stuff?
##########
extensions-core/lookups-cached-single/src/main/java/org/apache/druid/server/lookup/LoadingLookupFactory.java:
##########
@@ -111,6 +111,17 @@ public LookupIntrospectHandler getIntrospectHandler()
return null;
}
+ @Override
+ public void awaitInitialization()
+ {
+
Review Comment:
is there a reason the lookups-cached-single implementations don't implement
these methods? I don't think it necessarily needs to be a blocker for them to
be implemented for this PR if they should someday implement it, but a comment
on why or why not would be nice to leave here in the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
