kfaraz commented on code in PR #14857:
URL: https://github.com/apache/druid/pull/14857#discussion_r1297097344


##########
extensions-core/kafka-indexing-service/src/main/java/org/apache/druid/data/input/kafkainput/KafkaInputReader.java:
##########
@@ -128,6 +131,10 @@ private Map<String, Object> 
extractHeader(KafkaRecordEntity record)
     // the header list
     mergedHeaderMap.putIfAbsent(timestampColumnName, 
record.getRecord().timestamp());
 
+    // Add kafka record topic to the mergelist, we will skip record topic if 
the same key exists already in
+    // the header list

Review Comment:
   Nit:
   ```suggestion
       // Add kafka record topic to the mergelist, only if the key doesn't 
already exist
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to