kfaraz commented on PR #14857:
URL: https://github.com/apache/druid/pull/14857#issuecomment-1685936782

   > the default kafka topic name as null
   
   Do you mean the DEFAULT_TOPIC_COLUMN_NAME would be `null` and we check for 
`null` before adding it to the merged header? If yes, then I think that makes 
sense.
   
   Also, I guess what you had previously suggested wouldn't work, right? 
Because we seem to be adding the metadata columns even if they are not 
specified in the `dimensionsSpec`.
   > you just wouldn't add the column to your dimension spec. it's just like 
input format exposing 11 columns instead of 10 but you can choose to ingest 
only 10 of those.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to