abhishekagarwal87 commented on PR #14857:
URL: https://github.com/apache/druid/pull/14857#issuecomment-1683607007

   > This should be very helpful for debugging! Left some minor comments.
   > 
   > Edit: For ingestion from single topic, this column would have redundant 
data leading to unnecessary storage costs. How can we avoid populating it in 
such cases while still populating the other metadata columns such as 
`kafka.header.x` and `kafka.timestamp`?
   > 
   > We should also include a release note in the PR description and update the 
docs.
   
   @kfaraz - I suppose you just wouldn't add the column to your dimension spec. 
it's just like input format exposing 11 columns instead of 10 but you can 
choose to ingest only 10 of those. @vogievetsky - maybe we can make topic 
column optional in the console or detect in console if topicPattern is set and 
only then ask for kafka topic column name? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to