AmatyaAvadhanula commented on code in PR #14869:
URL: https://github.com/apache/druid/pull/14869#discussion_r1299848759
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -395,7 +396,7 @@ public void stop()
started = false;
- exec.shutdownNow();
+ stopAllDutyGroupExecutors();
Review Comment:
Why is this called when the lifecycle stops and not immediately when the
coordinator stops being the leader?
If the executors have scheduled long running duties, could it perform duties
and emit related metrics such as coordinator/time even after it has stopped
being the leader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
