kfaraz commented on code in PR #14869:
URL: https://github.com/apache/druid/pull/14869#discussion_r1299865521
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -395,7 +396,7 @@ public void stop()
started = false;
- exec.shutdownNow();
+ stopAllDutyGroupExecutors();
Review Comment:
No, duties do not run and metrics are not emitted if the coordinator is not
leader.
See
https://github.com/apache/druid/blob/3a75ee2098390922501e0993b8c29e9a85c42b3b/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java#L508-L515
But I guess it is better to call `stopAllDutyGroupExecutors` in
`stopBeingLeader` itself.
I don't want to run the whole CI just for this as it doesn't really make a
difference. I will address it in a follow up PR, unless there are other
comments in the current PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
