kfaraz opened a new pull request, #14869:
URL: https://github.com/apache/druid/pull/14869
### Motivation
Some coordinator duties such as `CompactSegments` or `KillUnusedSegments`
can be slow due to slowness on the Overlord or the metadata store. This causes
the coordinator executor to get blocked up thus delaying segment loading and
hand-offs, which in turn causes ingestion failures.
With the introduction of custom coordinator duties, it becomes imperative to
keep the core coordinator logic always unblocked.
### Changes
- Use separate executor for every duty group
- This change is thread-safe as every duty group uses its own copy of
`DruidCoordinatorRuntimeParams` and does not share any other mutable instances
with other duty groups.
- With the exception of `HistoricalManagementDuties`, duty groups are
typically not very compute intensive and mostly perform database or HTTP I/O.
So, coordinator resources would still mostly be available for
`HistoricalManagementDuties`.
### Alternative approach
Have 1 executor for `HistoricalManagementDuties` and 1 for all other duty
groups.
However, this still allows users to schedule some custom duties that compete
with say the `IndexingServiceDuties` or `MetadataStoreManagementDuties`.
---
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
