LakshSingla commented on code in PR #14886:
URL: https://github.com/apache/druid/pull/14886#discussion_r1305791226


##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteArraysQueryTest.java:
##########
@@ -3930,6 +3945,8 @@ public void testUnnestWithJoinOnTheLeft()
   {
     skipVectorize();
     cannotVectorize();
+    notMsqCompatible();
+    // @todo check this back

Review Comment:
   There's a `FrameBasedInlineJoinableFactory`. Can we accumulate the frames 
provided by the  `InputNumberDataSource` into memory, and then use the 
mentioned factory to facilitate joins? I presume this is happening because the 
RHS of the join is an input number data source. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to