cryptoe commented on code in PR #14886:
URL: https://github.com/apache/druid/pull/14886#discussion_r1314972171


##########
extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/exec/MSQSelectTest.java:
##########
@@ -2119,6 +2121,207 @@ public void testJoinUsesDifferentAlgorithm()
         .verifyResults();
   }
 
+  @Test
+  public void testSelectUnnestOnInlineFoo()

Review Comment:
   Please add tests cases for insert and replace q's as well. 
   They would be present in 
   MSQInsertTests, MSQReplaceTests. 
   
   I wonder if we should have some tests in which take in a select query and 
the framework makes the insert and the replace query from it. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to