somu-imply commented on code in PR #14886:
URL: https://github.com/apache/druid/pull/14886#discussion_r1316400658
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/BaseLeafFrameProcessor.java:
##########
@@ -96,7 +98,11 @@ private static Pair<List<ReadableFrameChannel>,
BroadcastJoinHelper> makeInputCh
final long memoryReservedForBroadcastJoin
)
{
- if (!(dataSource instanceof JoinDataSource) && !sideChannels.isEmpty()) {
+ // An UnnestDataSource or FilteredDataSource can have a join as a base
+ // In such a case a side channel is expected to be there
+ if (!(dataSource instanceof JoinDataSource
+ || dataSource instanceof UnnestDataSource
Review Comment:
Yes, a Filtered data source is a data source with a filter. It was
introduced for an issue where unnesting over a data source with a selector
filter was planned as a QueryDataSource instead of a table data source. A
FilteredDS is basically a base data source with a filter. It pushes a filter to
the data source and not requiring a query data source in between does not need
results to be materialized to the broker
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
