gianm commented on code in PR #14900: URL: https://github.com/apache/druid/pull/14900#discussion_r1307884483
########## processing/src/main/java/org/apache/druid/frame/field/NumericArrayFieldReader.java: ########## @@ -0,0 +1,182 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.frame.field; + +import org.apache.datasketches.memory.Memory; +import org.apache.druid.error.DruidException; +import org.apache.druid.query.extraction.ExtractionFn; +import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector; +import org.apache.druid.segment.ColumnValueSelector; +import org.apache.druid.segment.DimensionSelector; + +import javax.annotation.Nullable; +import java.util.ArrayList; +import java.util.List; + +public abstract class NumericArrayFieldReader implements FieldReader +{ + @Override + public DimensionSelector makeDimensionSelector( + Memory memory, + ReadableFieldPointer fieldPointer, + @Nullable ExtractionFn extractionFn + ) + { + // TODO: Should I throw an exception here Review Comment: You should do the same thing that numeric array columns do in regular segments. (I don't know what that is, but you should find out and then do the same thing.) ########## processing/src/main/java/org/apache/druid/frame/field/NumericFieldReader.java: ########## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.frame.field; + +import org.apache.datasketches.memory.Memory; +import org.apache.druid.common.config.NullHandling; +import org.apache.druid.query.extraction.ExtractionFn; +import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector; +import org.apache.druid.segment.ColumnValueSelector; +import org.apache.druid.segment.DimensionSelector; +import org.apache.druid.segment.column.ValueType; +import org.apache.druid.segment.column.ValueTypes; + +import javax.annotation.Nonnull; +import javax.annotation.Nullable; + +public abstract class NumericFieldReader<T extends Number> implements FieldReader +{ + + private final byte nullIndicatorByte; + + public NumericFieldReader(boolean forArray) + { + if (!forArray) { + this.nullIndicatorByte = NumericFieldWriter.NULL_BYTE; + } else { + this.nullIndicatorByte = NumericFieldWriter.ARRAY_NULL_BYTE; + } + } + + @Override + public ColumnValueSelector<?> makeColumnValueSelector(Memory memory, ReadableFieldPointer fieldPointer) + { + return new Selector(memory, fieldPointer); + } + + @Override + public DimensionSelector makeDimensionSelector( + Memory memory, + ReadableFieldPointer fieldPointer, + @Nullable ExtractionFn extractionFn + ) + { + return ValueTypes.makeNumericWrappingDimensionSelector( + getValueType(), + makeColumnValueSelector(memory, fieldPointer), + extractionFn + ); + } + + @Override + public boolean isNull(Memory memory, long position) + { + return memory.getByte(position) == nullIndicatorByte; + } + + @Override + public boolean isComparable() + { + return true; + } + + public abstract ValueType getValueType(); + + public abstract Class<? extends T> getClassOfObject(); + + public abstract T getValueFromMemory(Memory memory, long position); Review Comment: Unfortunately this design requires boxing, whereas the previous design didn't. Is it possible to update this design to avoid boxing and therefore avoid the cost of the additional allocations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
