gianm commented on code in PR #14900:
URL: https://github.com/apache/druid/pull/14900#discussion_r1341495434


##########
processing/src/main/java/org/apache/druid/frame/write/FrameWriterUtils.java:
##########
@@ -172,6 +174,40 @@ public static List<ByteBuffer> 
getUtf8ByteBuffersFromStringArraySelector(
     return retVal;
   }
 
+  @Nullable
+  public static List<? extends Number> getNumericArrayFromNumericArray(Object 
row)

Review Comment:
   This method needs some javadoc, because the name is unclear. ("Numeric array 
from numeric array")
   
   Also, reading through the impl I think that `numericArrayAsList` would be a 
better name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to