AmatyaAvadhanula commented on code in PR #14938:
URL: https://github.com/apache/druid/pull/14938#discussion_r1314610228


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/NoopTask.java:
##########
@@ -159,17 +143,8 @@ public void stopGracefully(TaskConfig taskConfig)
   @Override
   public TaskStatus runTask(TaskToolbox toolbox) throws Exception
   {
-    if (firehoseFactory != null) {
-      log.info("Connecting firehose");
-    }
-    try (Firehose firehose = firehoseFactory != null ? 
firehoseFactory.connect(null, null) : null) {
-
-      log.info("Running noop task[%s]", getId());
-      log.info("Sleeping for %,d millis.", runTime);

Review Comment:
   Could this logging be useful for understanding test runs better?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to