kfaraz commented on code in PR #14938:
URL: https://github.com/apache/druid/pull/14938#discussion_r1314623912
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/NoopTask.java:
##########
@@ -159,17 +143,8 @@ public void stopGracefully(TaskConfig taskConfig)
@Override
public TaskStatus runTask(TaskToolbox toolbox) throws Exception
{
- if (firehoseFactory != null) {
- log.info("Connecting firehose");
- }
- try (Firehose firehose = firehoseFactory != null ?
firehoseFactory.connect(null, null) : null) {
-
- log.info("Running noop task[%s]", getId());
- log.info("Sleeping for %,d millis.", runTime);
Review Comment:
No, I don't see it adding much value. These logs fill up the logs and make
it difficult to find important things such as warnings and errors.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/NoopTask.java:
##########
@@ -159,17 +143,8 @@ public void stopGracefully(TaskConfig taskConfig)
@Override
public TaskStatus runTask(TaskToolbox toolbox) throws Exception
{
- if (firehoseFactory != null) {
- log.info("Connecting firehose");
- }
- try (Firehose firehose = firehoseFactory != null ?
firehoseFactory.connect(null, null) : null) {
-
- log.info("Running noop task[%s]", getId());
- log.info("Sleeping for %,d millis.", runTime);
Review Comment:
No, I don't see it adding much value. Such messages only fill up the logs
and make it difficult to find important things such as warnings and errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
