AmatyaAvadhanula commented on code in PR #14938:
URL: https://github.com/apache/druid/pull/14938#discussion_r1314619429
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/NoopTask.java:
##########
@@ -67,18 +62,14 @@ enum IsReadyResult
@JsonIgnore
private final IsReadyResult isReadyResult;
- @JsonIgnore
- private final FirehoseFactory firehoseFactory;
-
@JsonCreator
public NoopTask(
@JsonProperty("id") String id,
@JsonProperty("groupId") String groupId,
@JsonProperty("dataSource") String dataSource,
- @JsonProperty("runTime") long runTime,
+ @JsonProperty("runTime") long runTimeMillis,
@JsonProperty("isReadyTime") long isReadyTime,
@JsonProperty("isReadyResult") String isReadyResult,
Review Comment:
Is a non-null value being passed for `isReadyResult`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
