xvrl commented on code in PR #14827:
URL: https://github.com/apache/druid/pull/14827#discussion_r1317625016
##########
server/src/test/java/org/apache/druid/client/cache/MemcachedCacheTest.java:
##########
@@ -224,6 +217,37 @@ public void emit(Event event)
}
}
+ @Test
+ public void testSslConnection()
+ {
+ final MemcachedCacheConfig config = new MemcachedCacheConfig()
+ {
+ @Override
+ public boolean enableTls()
+ {
+ return true;
+ }
+
+ @Override
+ public String getHosts()
+ {
+ return "localhost:9999";
+ }
+ };
+ // Static Mode
+ Assert.assertEquals(config.getClientMode(), "static");
Review Comment:
this test seems to ensure that the default client mode is static, which is
fine, but it doesn't actually do what the test name suggests, which is to
verify that ssl is configured. Can we move this to its own test to verify the
default?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
