xvrl commented on code in PR #14827:
URL: https://github.com/apache/druid/pull/14827#discussion_r1305929285


##########
docs/configuration/index.md:
##########
@@ -2103,16 +2103,18 @@ In addition to the normal cache metrics, the caffeine 
cache implementation also
 
 Uses memcached as cache backend. This allows all processes to share the same 
cache.
 
-|Property|Description|Default|
-|--------|-----------|-------|
-|`druid.cache.expiration`|Memcached [expiration 
time](https://code.google.com/p/memcached/wiki/NewCommands#Standard_Protocol).|2592000
 (30 days)|
-|`druid.cache.timeout`|Maximum time in milliseconds to wait for a response 
from Memcached.|500|
-|`druid.cache.hosts`|Comma separated list of Memcached hosts 
`<host:port>`.|none|
-|`druid.cache.maxObjectSize`|Maximum object size in bytes for a Memcached 
object.|52428800 (50 MiB)|
-|`druid.cache.memcachedPrefix`|Key prefix for all keys in Memcached.|druid|
-|`druid.cache.numConnections`|Number of memcached connections to use.|1|
-|`druid.cache.protocol`|Memcached communication protocol. Can be binary or 
text.|binary|
-|`druid.cache.locator`|Memcached locator. Can be consistent or 
array_mod.|consistent|
+| Property                      | Description                                  
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                   | Default           |
+|-------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|-------------------|
+| `druid.cache.expiration`      | Memcached [expiration 
time](https://code.google.com/p/memcached/wiki/NewCommands#Standard_Protocol).  
                                                                                
                                                                                
                                                                                
                                                                                
                                          | 2592000 (30 days) |
+| `druid.cache.timeout`         | Maximum time in milliseconds to wait for a 
response from Memcached.                                                        
                                                                                
                                                                                
                                                                                
                                                                                
                     | 500               |
+| `druid.cache.hosts`           | Comma separated list of Memcached hosts 
`<host:port>`. Needed only when druid.cache.clientMode=static. Dynamic mode 
[automatically identifies nodes in your 
cluster](https://docs.aws.amazon.com/AmazonElastiCache/latest/mem-ug/AutoDiscovery.html)
                                                                                
                                                                                
                                                            | none              
|
+| `druid.cache.maxObjectSize`   | Maximum object size in bytes for a Memcached 
object.                                                                         
                                                                                
                                                                                
                                                                                
                                                                                
                   | 52428800 (50 MiB) |
+| `druid.cache.memcachedPrefix` | Key prefix for all keys in Memcached.        
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                   | druid             |
+| `druid.cache.numConnections`  | Number of memcached connections to use.      
                                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                   | 1                 |
+| `druid.cache.protocol`        | Memcached communication protocol. Can be 
binary or text.                                                                 
                                                                                
                                                                                
                                                                                
                                                                                
                       | binary            |
+| `druid.cache.locator`         | Memcached locator. Can be consistent or 
array_mod.                                                                      
                                                                                
                                                                                
                                                                                
                                                                                
                        | consistent        |
+| `druid.cache.enableTls`       | Use TLS based ssl connection for Memcached 
client.  Boolean                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                     | false             |

Review Comment:
   nit, ssl is redundant here
   ```suggestion
   | `druid.cache.enableTls`       | enable TLS based connection for Memcached 
client.  Boolean                                                                
                                                                                
                                                                                
                                                                                
                                                                                
                     | false             |
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to