xvrl commented on code in PR #14827:
URL: https://github.com/apache/druid/pull/14827#discussion_r1305921575


##########
server/src/test/java/org/apache/druid/client/cache/MemcachedCacheTest.java:
##########
@@ -224,6 +217,26 @@ public void emit(Event event)
     }
   }
 
+  @Test
+  public void testSslConnection()
+  {
+    final MemcachedCacheConfig config = new MemcachedCacheConfig()
+    {
+      @Override
+      public boolean enableTls()
+      {
+        return true;
+      }
+
+      @Override
+      public String getHosts()
+      {
+        return "localhost:9999";
+      }
+    };
+    MemcachedCache.create(config);

Review Comment:
   this doesn't seem to test much other than making sure setting enableTls 
doesn't error out. Can we at least have the test somehow verify that the client 
has tls enabled?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to